Add related span for mixin constructor error #28319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Nov 2, 2018
src/compiler/checker.ts
Outdated
| const err = error(baseTypeNode.expression, Diagnostics.Type_0_is_not_a_constructor_function_type, typeToString(baseConstructorType)); | ||
| if (baseConstructorType.flags & TypeFlags.TypeParameter) { | ||
| const constraint = getConstraintFromTypeParameter(baseConstructorType); | ||
| let elaborated = false; |
There was a problem hiding this comment.
instead of mutating let elaborated = false, I think you can just let ctorReturn = unknownType; and mutate that in the innermost if.
src/compiler/checker.ts
Outdated
| } | ||
| } | ||
| if (!elaborated) { | ||
| addRelatedInfo(err, createDiagnosticForNode(baseConstructorType.symbol.declarations[0], Diagnostics.Did_you_mean_for_0_to_be_constrained_to_type_new_args_Colon_any_1, symbolToString(baseConstructorType.symbol), typeToString(unknownType))); |
There was a problem hiding this comment.
If you swap mutable elaborated for mutable ctorReturn, you can forgo the if and just say typeToString(ctorReturn)
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17504